Updated version of Signing changes#651
Open
Penguinwizzard wants to merge 22 commits intomicrosoft:masterfrom
Open
Updated version of Signing changes#651Penguinwizzard wants to merge 22 commits intomicrosoft:masterfrom
Penguinwizzard wants to merge 22 commits intomicrosoft:masterfrom
Conversation
…e things happy. Also need lots of polish.
Penguinwizzard
requested review from
JohnMcPMS,
kyelamarthi1,
msftrubengu,
ranm-msft and
sachinkumar-2106
as code owners
JohnMcPMS
reviewed
Oct 22, 2024
Member
JohnMcPMS
left a comment
JohnMcPMS
left a comment
There was a problem hiding this comment.
Reviewed only the changes by @Penguinwizzard , as it seems unhelpful to review my own changes even if I am 5 years removed from them. My memory is that these changes were working on the golden path but lacked any automated tests. That time requirement was the reason they never got checked in. Ultimately I think that this still needs to be addressed to merge.
Member
Author
|
I've now added some automated tests, albeit fairly simple ones - they pack an MSIX, sign it, and then validate its signature and contents. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of johnmcpms/signing on the latest version of microsoft/msix-packaging@master, with a couple of small patches to get it working (and handling pfx passwords). Ideally, with a simpler history and a few of the merge fixes rolled in, this should be an easier change to land than the existing branches where multiple contributors have done repeated merges of master into the topic branch.