Open
Conversation
added 2 commits
April 28, 2025 11:47
This brings over changes Office needs to build so we can more easily migrate changes in the future. 1. Comment out a bunch of unreferenced parameters. 2. Explicitly cast in comparisons 3. A few optimizations 4. Some SAL annotations 5. Remove typedef from enums. Specify default storage type for enums. 6. Remove problmatic unused ZipObject and ZipObjectWriter ctors 7. Remove u8 from char* definitions. This is incompatible with C++20 which would need to us char8_t* 8. Use localtime_s over localtime. This ctor doesn't set m_localTime so I'm not sure if this even matters. 9. Use LONG instead of long. These have different types on cross platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings over changes Office needs to build so we can more easily migrate changes in the future.