Skip to content

Allow minus sign in point wkt #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow minus sign in point wkt #2819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSpatialDatatype.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,8 @@ void readPointWkt() throws SQLServerException {

while (currentWktPos < wkt.length()
&& (Character.isDigit(wkt.charAt(currentWktPos)) || wkt.charAt(currentWktPos) == '.'
|| wkt.charAt(currentWktPos) == 'E' || wkt.charAt(currentWktPos) == 'e')) {
|| wkt.charAt(currentWktPos) == 'E' || wkt.charAt(currentWktPos) == 'e'
|| wkt.charAt(currentWktPos) == '-')) {
currentWktPos++;
}

Expand Down
12 changes: 12 additions & 0 deletions src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2122,6 +2122,18 @@ public void testLargeCases() throws SQLException {
}
}

/**
* Tests Geography almost zero coordinates like 0.0001234. The string representation is "1.234E-4", which
* caused a bug when creating a Geography object.
*/
@Test
public void testGeographySmallCoordinates() throws SQLException {
Geography g = Geography.point(0.0001234, 1.234, 4326);

assertEquals(0.0001234, g.getLatitude());
assertEquals(1.234, g.getLongitude());
}

private void beforeEachSetup() throws SQLException {
try (Statement stmt = connection.createStatement()) {
TestUtils.dropTableIfExists(AbstractSQLGenerator.escapeIdentifier(geomTableName), stmt);
Expand Down