This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Scatter ops for webworker#220
Open
Manojbhat09 wants to merge 1 commit intomicrosoft:masterfrom
Manojbhat09:master
Open
Scatter ops for webworker#220Manojbhat09 wants to merge 1 commit intomicrosoft:masterfrom Manojbhat09:master
Manojbhat09 wants to merge 1 commit intomicrosoft:masterfrom
Manojbhat09:master
Conversation
Author
|
When I do npm run pre-commit it gives this error: |
Contributor
the pre-commit hook failed to launch. did you run |
fs-eire
reviewed
Sep 2, 2020
| "test_flatten_default_axis", | ||
| "test_gather_0", | ||
| "test_gather_1", | ||
| "test_scatter_0", |
Contributor
There was a problem hiding this comment.
this test does not exist. please see https://github.com/onnx/onnx/tree/master/onnx/backend/test/data/node
Author
|
Hi @fs-eire I actually created a test for this and it works. Do I create a new pull request now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to implement the pytorch scatter (torch.scatter) for an application.
This is valid with onnx scatter too.
And works