This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Open
Conversation
hanbitmyths
approved these changes
Sep 11, 2020
Collaborator
hanbitmyths
left a comment
hanbitmyths
left a comment
There was a problem hiding this comment.
Regarding test cases failure, I think this review has a dependency with interface change, right? Please, double-check and merger after all tests are passed.
| if (this.opset > 10) { | ||
| this.roiInputIdx = 1; | ||
| this.scalesInputIdx = 2; | ||
| this.sizesInputIdx = 3; |
Collaborator
There was a problem hiding this comment.
sizesInputIdx is not initialized when opset is 9, but it seems it's always used by prepare(). Am I missing something here? roiInputIdx is also not initialized, but no direct path to be used by index is here.
debkbanerji
reviewed
Dec 21, 2020
lib/ops/upsample.ts
Outdated
| this.roiInputIdx = 1; | ||
| this.scalesInputIdx = 2; | ||
| this.sizesInputIdx = 3; | ||
| } else if (this.opset === 9) { |
There was a problem hiding this comment.
I ran into an issue when trying to use this when this.opset was 10. In my particular use case, adding || this.opset === 10 caused the inference to run as expected, but I am not an expert regarding this codebase.
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* wasm: support int32 for Add, Sub and Mul * enable test cases only for WASM
Switch statement does not handle disjunction as a list of cases. Consider writing separate cases for each. Co-authored-by: Yulong Wang <yulongw@microsoft.com>
Testing a collection size for < 0 will always be false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses unified implementation that works with
Upsamplev7,Upsamplev9,Resizev10 andResizev11, in both CPU and WebGL backends. Depend on #227 to build.