Remove 10.14 suffix from osx nuget package#865
Remove 10.14 suffix from osx nuget package#865jeffpardy wants to merge 4 commits intomicrosoft:mainfrom
Conversation
|
Thanks @wenbingl! |
|
@jeffpardy The changes look fine to me. I'm not very familiar with the NuGet setup though. Were you able to verify that this fixes the issues you encountered? |
|
I can verify that it fixes runtime error and no longer requires custom |
There was a problem hiding this comment.
Should all these directories move to be 'net8.0-...' given net8 is the lowest version currently supported?
The xamarin targets (monoandroid11.0 and xamarinios10) can be deleted as well.
There was a problem hiding this comment.
Sorry @skottmckay I was away for a bit. Not opposed to that cleanup but would it be ok to do as a separate pull request? Just thinking it might increase the blast radius of this particular change?
|
Hi @jeffpardy and team 👋, |
Updates the specified runtime for osx to remove the OS specific RID. This is no longer supported since .NET 8 and generates the following warning as well as runtime errors.
Matches the same changes made in
microsoft/onnxruntimewith microsoft/onnxruntime#17277Build Warning
Runtime Error