feat(agents): thin GHCP cloud-agent wrapper exposing hve-core RPI#610
Open
feat(agents): thin GHCP cloud-agent wrapper exposing hve-core RPI#610
Conversation
* Add Physical-AI RPI umbrella with bootstrap verification, physical-AI overlay, persona-based subagent dispatch, and PR-comment persistence * Add hidden Physical-AI RPI Worker shell that resolves persona name to bootstrapped microsoft/hve-core subagent body * Bootstrap microsoft/hve-core@main rpi-agent and subagents into .copilot-tracking/upstream/hve-core-rpi/ during copilot-setup-steps 🤖 - Generated by Copilot
…tructions - clarify artifact persistence and PR comment usage - enhance descriptions for RPI and Worker agents - add cloud-agent RPI wrapper instructions to general guidelines 🔒 - Generated by Copilot Co-authored-by: Copilot <copilot@github.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 65.16% 67.70% +2.53%
==========================================
Files 251 263 +12
Lines 15597 16827 +1230
Branches 2152 2290 +138
==========================================
+ Hits 10164 11392 +1228
Misses 5142 5142
- Partials 291 293 +2
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Thank you for this contribution! The two-agent split design is well-reasoned and the rationale is clearly documented. I'm interested in seeing how this works out so I can do something similar for other agents/workflows from hve-core in edge-ai and physical-ai-toolchain. Left a few minor comments.
…gent files - add upstream-source comments for clarity - update SHA references in copilot setup steps - correct date in copilot artifacts documentation 🔧 - Generated by Copilot Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a thin wrapper that surfaces the autonomous Research → Plan → Implement → Review workflow from
microsoft/hve-coreinside GitHub Copilot cloud-agent sessions for this repo Physical AI Toolchain. Two custom agent profiles plus one workflow step are all that is required: the umbrella Physical-AI RPI appears in the cloud-agent picker, while a hidden generic worker Physical-AI RPI Worker loads any upstream hve-core subagent body by name at dispatch time. The upstream personas are pulled fresh on every session boot by a newBootstrap hve-core RPI personastep incopilot-setup-steps.yml, which runs outside the cloud-agent firewall and writes the bodies into the workspace before the agent starts.Closes #609.
Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationAlso touches
.github/agents/,.github/workflows/copilot-setup-steps.yml, and.github/copilot-instructions.md(custom agent surface and bootstrap workflow).Changes
New cloud-agent profiles
Both files target
github-copilotonly and stay well under the 30,000-character cloud-agent prompt cap..github/agents/physical-ai-rpi.agent.md. Performs bootstrap verification against_audit.md, adopts the upstream RPI procedure, applies a physical-AI overlay (Isaac Sim ABI pinnumpy>=1.26.0,<2.0.0, CUDA/cuDNN drift inevaluation/**/Dockerfile*andDockerfile.lerobot-eval, terraformazurermmajor-bump caution, dataviewer FastAPI/React surfaces), and dispatches subagents via theagenttool with apersona: <stem>payload. Holds thegithub/add_pull_request_commentandgithub/update_pull_requestMCP tools so phase artifacts post directly to the PR..github/agents/physical-ai-rpi-worker.agent.md. Markeduser-invocable: falseanddisable-model-invocation: true, so it is hidden from the picker and reachable only via the umbrella. Validates thepersonaname against^[a-z][a-z0-9-]*$, resolves to.copilot-tracking/upstream/hve-core-rpi/subagents/<persona>.agent.md, and adopts that body verbatim. Read-only on github; never commits or dispatches further.Always-latest-main bootstrap
.github/workflows/copilot-setup-steps.yml. Resolvesmicrosoft/hve-core@mainto a concrete SHA viagh api, downloads the umbrellarpi-agent.agent.md, enumerates the upstreamsubagents/directory, downloads each*.agent.md, and writes an_audit.mdrecording the resolved SHA and discovered subagent list. The step runs outside the cloud-agent firewall (per the customize-the-agent-firewall docs) so it can reachraw.githubusercontent.com, which the cloud-agent itself cannot.continue-on-error: truekeeps a transient upstream fetch failure from blocking session boot — the umbrella's Step 0 detects missing files and reports the failure as a PR comment.Documentation and registry
.github/copilot-instructions.mdwith a new Cloud-Agent RPI Wrapper subsection summarising the bootstrap step and the umbrella/worker pair.docs/reference/copilot-artifacts.mdwith two new rows in the agent registry table and a reference section explaining the four reasons the two-agent split is necessary on the cloud-agent surface.Testing Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)This PR ships only custom agent profiles, a setup-steps workflow step, and documentation. The standard test matrix above does not apply. Manual smoke test plan: after merge, assign a small task to the Physical-AI RPI agent in the cloud-agent picker and verify (a) the bootstrap step logs a resolved hve-core SHA, (b)
_audit.mdlists at least theresearcher-subagentandphase-implementorpersonas, (c) Research / Plan / Implement / Review phases each post a<details>-wrapped PR comment, and (d) the PR description carries an "🧭 RPI Artifact Index" block linking to those comment URLs.Documentation Impact
Bug Fix Checklist
Not applicable — this is a new feature, not a bug fix.
Checklist
npm run lint:md,npm run spell-check,npm run lint:yamlclean for changed files; the two pre-existingdatasets/lerobot/README.mderrors are unrelated to this PR)