Skip to content

chore(bidi): don't set Accept-Language header for a locale override #38196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

chore(bidi): don't set Accept-Language header for a locale override #38196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/playwright-core/src/server/bidi/bidiBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export class BidiBrowserContext extends BrowserContext {
userContexts: [this._userContextId()],
}));
}
if (this._options.extraHTTPHeaders || this._options.locale)
if (this._options.extraHTTPHeaders)
promises.push(this.doUpdateExtraHTTPHeaders());
await Promise.all(promises);
}
Expand Down Expand Up @@ -326,9 +326,7 @@ export class BidiBrowserContext extends BrowserContext {
}

async doUpdateExtraHTTPHeaders(): Promise<void> {
let allHeaders = this._options.extraHTTPHeaders || [];
if (this._options.locale)
allHeaders = network.mergeHeaders([allHeaders, network.singleHeader('Accept-Language', this._options.locale)]);
const allHeaders = this._options.extraHTTPHeaders || [];
await this._browser._browserSession.send('network.setExtraHeaders', {
headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),
userContexts: [this._userContextId()],
Expand Down
2 changes: 0 additions & 2 deletions packages/playwright-core/src/server/bidi/bidiPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,9 @@ export class BidiPage implements PageDelegate {
}

async updateExtraHTTPHeaders(): Promise<void> {
const locale = this._browserContext._options.locale;
const allHeaders = network.mergeHeaders([
this._browserContext._options.extraHTTPHeaders,
this._page.extraHTTPHeaders(),
locale ? network.singleHeader('Accept-Language', locale) : undefined,
]);
await this._session.send('network.setExtraHeaders', {
headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),
Expand Down
Loading