Skip to content

fix(binder): fix member ordering lint violation in Binder class #11390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StellaHuang95 merged 1 commit into from
Apr 15, 2026
+18 −18
Merged

fix(binder): fix member ordering lint violation in Binder class #11390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions packages/pyright-internal/src/analyzer/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,24 +1209,6 @@ export class Binder extends ParseTreeWalker {
return false;
}

// Helper method to determine if an expression is a non-empty list or tuple literal.
// This is a syntactic check, not a semantic one, so it's very fast.
// Guards against starred expressions ([*empty_list]) and comprehensions ([v for v in []]).
private _isNonEmptyListOrTupleLiteral(expr: ExpressionNode): boolean {
if (expr.nodeType === ParseNodeType.List) {
return (
expr.d.items.length > 0 &&
expr.d.items.every(
(item) => item.nodeType !== ParseNodeType.Unpack && item.nodeType !== ParseNodeType.Comprehension
)
);
}
if (expr.nodeType === ParseNodeType.Tuple) {
return expr.d.items.length > 0 && expr.d.items.every((item) => item.nodeType !== ParseNodeType.Unpack);
}
return false;
}

override visitFor(node: ForNode) {
this._bindPossibleTupleNamedTarget(node.d.targetExpr);
this._addInferredTypeAssignmentForVariable(node.d.targetExpr, node);
Expand Down Expand Up @@ -2502,6 +2484,24 @@ export class Binder extends ParseTreeWalker {
return true;
}

// Helper method to determine if an expression is a non-empty list or tuple literal.
// This is a syntactic check, not a semantic one, so it's very fast.
// Guards against starred expressions ([*empty_list]) and comprehensions ([v for v in []]).
private _isNonEmptyListOrTupleLiteral(expr: ExpressionNode): boolean {
if (expr.nodeType === ParseNodeType.List) {
return (
expr.d.items.length > 0 &&
expr.d.items.every(
(item) => item.nodeType !== ParseNodeType.Unpack && item.nodeType !== ParseNodeType.Comprehension
)
);
}
if (expr.nodeType === ParseNodeType.Tuple) {
return expr.d.items.length > 0 && expr.d.items.every((item) => item.nodeType !== ParseNodeType.Unpack);
}
return false;
}

private _addTypingImportAliasesFromBuiltinsScope() {
if (!this._fileInfo.builtinsScope) {
return;
Expand Down
Loading