Skip to content

Fix timeout counter synchronization #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunilsurana wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Fix timeout counter synchronization #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8709196
Fix timeout calculation in page
Dec 15, 2021
0b3a88a
fix timeout tracking
Dec 15, 2021
a114e16
resolve merge conflicts
Dec 15, 2021
c156481
Fix code review comment
Dec 15, 2021
94cc353
Merge branch 'main' into fixtimeout
Dec 15, 2021
2428b0c
Reduce timeout for long timeouts
Dec 15, 2021
09061fc
update version
Dec 15, 2021
53cad8d
fix flakiness by adjusting timeouts
Dec 16, 2021
ca15f20
fix flakiness by adjusting timeouts
Dec 16, 2021
769cdd9
fix flakiness by adjusting timeouts
Dec 16, 2021
93e3917
fix flakiness by adjusting timeouts
Dec 16, 2021
bb959fa
fix flakiness by adjusting timeouts
Dec 16, 2021
69678cd
Fix code review comment
Dec 16, 2021
1ea36b0
add await
Dec 16, 2021
5d737c8
log cores information
Dec 16, 2021
6b2d5fb
Delete launch.json
sunilsurana Dec 16, 2021
e375c92
Merge branch 'main' into fixtimeout
Dec 16, 2021
bb8139f
Fix previos code review comment
Dec 16, 2021
ac5b42f
Merge branch 'fixtimeout' of https://github.com/microsoft/storywright…
Dec 16, 2021
a225e05
fix keypress
Dec 17, 2021
7d885dc
Merge branch 'main' into fixtimeout
Dec 17, 2021
24252b3
update version
Dec 17, 2021
151f75d
Merge branch 'main' into fixtimeout
Dec 17, 2021
3fd9a9f
Fix timeout counter update synchronization
Dec 17, 2021
2fb16cd
Code review comment
Dec 17, 2021
2a03558
add async to function
Dec 17, 2021
9f6f4ec
Updating playwright to latest version
sunilsurana Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"types": "lib/index.d.ts",
"dependencies": {
"@types/react": "^17.0.8",
"playwright": "^1.11.1",
"playwright": "^1.17.1",
"react": "^17.0.2",
"yargs": "^16.2.0"
},
Expand Down
12 changes: 6 additions & 6 deletions src/StoryWrightProcessor/PlayWrightExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,23 +53,23 @@ export class PlayWrightExecutor {
const _setTimeout = window.setTimeout;
const _clearTimeout = window.clearTimeout;

window.clearTimeout = (timeoutId) => {
window.clearTimeout = async (timeoutId) => {
_clearTimeout(timeoutId);
window.__pwBusy__("timeouts--",timeoutId);
await window.__pwBusy__("timeouts--",timeoutId);
}

window.setTimeout = function(fn, delay, params) {
window.setTimeout = async function(fn, delay, params) {
const isInNearFuture = delay < 1000 * 7;
var timeoutId = _setTimeout(function() {
var timeoutId = _setTimeout(async function() {
try {
fn && fn(params);
}
finally {
window.__pwBusy__("timeouts--",timeoutId);
await window.__pwBusy__("timeouts--",timeoutId);
}
}, delay);
if (isInNearFuture) {
window.__pwBusy__("timeouts++",timeoutId);
await window.__pwBusy__("timeouts++",timeoutId);
}
return timeoutId;
}
Expand Down