Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the microsoft-teams-cards Adaptive Cards generated core models to the latest codegen output (03/18/2026), reapplies repo-specific serialization/validation aliasing, introduces deprecation warnings for legacy action helper classes, and changes the default Adaptive Card schema version to 1.5 (to address #238).
Changes:
- Regenerated
cards/core.pywith new/updated Adaptive Card model types, defaults, and helpers (including defaultAdaptiveCard.version = "1.5"). - Reapplied custom alias behavior (
ms_teams⇄msteams,choices_data⇄choices.data) and kept theSubmitActionData.with_datahelper. - Added runtime
DeprecationWarningto legacy action classes (IMBackAction,InvokeAction,MessageBackAction,SignInAction,TaskFetchAction) pointing to generated replacements.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cards/src/microsoft_teams/cards/core.py | Updated generated Adaptive Cards core models; aliasing logic; default AdaptiveCard.version change; new/modified types. |
| packages/cards/src/microsoft_teams/cards/actions/task_fetch_action.py | Adds deprecation warning for TaskFetchAction. |
| packages/cards/src/microsoft_teams/cards/actions/sign_in_action.py | Adds deprecation warning for SignInAction. |
| packages/cards/src/microsoft_teams/cards/actions/message_back_action.py | Adds deprecation warning for MessageBackAction. |
| packages/cards/src/microsoft_teams/cards/actions/invoke_action.py | Adds deprecation warning for InvokeAction. |
| packages/cards/src/microsoft_teams/cards/actions/im_back_action.py | Adds deprecation warning for IMBackAction. |
added 9 commits
March 19, 2026 15:25
dfc6252 to
8711ede
Compare
lilyydu
reviewed
Mar 20, 2026
packages/cards/src/microsoft_teams/cards/actions/im_back_action.py
Outdated
Show resolved
Hide resolved
lilyydu
approved these changes
Mar 23, 2026
corinagum
commented
Mar 24, 2026
Contributor
Author
corinagum
left a comment
There was a problem hiding this comment.
left some comments/questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ms_teams>msteamsalias in serialization/validation generators[choices_data>choices.data](ae371c5) alias in serialization/validation generators[with_datahelper method onSubmitActionData](Add with_data for SubmitActionData (#165) · microsoft/teams.py@294e32c)IMBackAction,InvokeAction,MessageBackAction,SignInAction, andTaskFetchActionwithDeprecationWarning, pointing to their generated replacementsmsteamsadded to several types:AdaptiveCard,SubmitAction,Image,SubmitActionDataExecuteAction.data:Union[str, Dict[str, Any], SubmitActionData]changed toUnion[str, SubmitActionData](dropped dict)