Fix HttpServer breaking Azure App Service named pipe ports#488
Open
heyitsaamir wants to merge 3 commits intomainfrom
Open
Fix HttpServer breaking Azure App Service named pipe ports#488heyitsaamir wants to merge 3 commits intomainfrom
heyitsaamir wants to merge 3 commits intomainfrom
Conversation
These two markdown files are all a human needs to write — the e2e testing skill generates and manages the actual Playwright test code from here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove parseInt coercion in HttpServer.start() that converted named pipe paths (e.g. \\.\pipe\...) to NaN on Azure App Service. Pass port through as-is since Node's http.Server.listen() natively handles both numbers and pipe strings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #487. SDK v2.0.6 broke deployments on Azure App Service because
HttpServer.start()calledparseInt()on thePORTenvironment variable, which on Azure App Service (IIS + iisnode) is a Windows named pipe path (e.g.\\.\pipe\507cb72a-...), not a numeric port. This returnedNaN, causing the server to never bind and all requests to time out.The fix removes the
parseIntcoercion and passes the port value through as-is to the adapter. Node'shttp.Server.listen()natively supports both numeric ports and named pipe strings. TheIHttpServerAdapter.start()andExpressAdapter.start()signatures are widened fromnumbertonumber | stringto match.