Skip to content

OutputDebugString Added #19073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OutputDebugString Added #19073

wants to merge 1 commit into from

Conversation

vivekcpu
Copy link

@vivekcpu vivekcpu commented Jun 26, 2025

Summary of the Pull Request

OutputDebugString is added in init.cpp

References and Relevant Issues

In the file Since, DllMain returns TRUE unconditionally and ignores the reason, initialization failures may go undetected.

Detailed Description of the Pull Request / Additional comments

Added logging or conditionally handle reason for checking all the possible Reason and minimizing the risk of failures.

Validation Steps Performed

This switch block doesn't validate input values explicitly, but it validates program execution flow by tracking which DllMain event occurs.

Validation Goal || How This Code Helps

Confirm DLL is loaded correctly | "DLL loaded (PROCESS_ATTACH)" is logged
Confirm DLL is unloaded correctly | "DLL unloaded (PROCESS_DETACH)" is logged
Debug thread-level loading/unloading | Thread attach/detach messages will appear
Validate lifecycle flow of DLL | You see the exact sequence of OS interactions

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@vivekcpu
Copy link
Author

@vivekcpu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@vivekcpu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@vivekcpu
Copy link
Author

i agree with the CLA guidelines

Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 26, 2025
@vivekcpu vivekcpu requested a review from lhecker June 26, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants