autoimport completions #1553

iisaduan · 2025-08-11T03:46:29Z

This PR implements autoimports, and allows symbols to be autoimported through completions. Also ports the basic functionalities of the changetracker (adds changes and calculates/formats the output string).

demo (note: the formatting has been fixed, see test cases)

corsa.completion.autoimports.1.mp4

Notes on implementation:

Caching structures (like ExportInfoMap, ImportMap, etc) have been ported for functionality, but are not saved between server requests). After the ls is more fully implemented and perf tested, we will revisit to see what caching we need to do
The IncludeCompletionsForModuleExports and IncludeCompletionsForImportStatements in the UserPreferences passed into any completion get/resolve request has been set to true to allow autoimports to work autoimport completions #1553 (comment)
changetracker formatting workarounds: autoimport completions #1553 (comment)

Related features to be implemented after this PR:

autoimport user settings/format settings
package json autoimport provider (probably mostly a rewrite)
organize imports
codefix provider (to be able to use autoimports without completions)

…o autoimport

alexwork1611 · 2025-08-11T14:36:56Z

I'm gonna closely follow this one...

iisaduan · 2025-08-11T16:00:41Z

bug squashing atm :). Hopefully it'll be ready soon

internal/ls/completions.go

internal/ls/types.go

internal/ls/completions.go

internal/fourslash/fourslash.go

internal/scanner/scanner.go

internal/ls/completions.go

Copilot

Pull Request Overview

This PR implements autoimports functionality, enabling automatic import suggestions through completions in the TypeScript language server. The implementation adds the ability to suggest and automatically import symbols from other modules when typing identifiers.

Key changes include:

Added comprehensive autoimport completion system with export info mapping and module specifier resolution
Implemented import statement completion support for various import syntaxes
Added text change tracking infrastructure for code modifications

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`internal/ls/completions.go`	Main autoimport logic including export collection, module specifier resolution, and completion item generation
`internal/ls/autoimportstypes.go`	Type definitions for import/export kinds, import fixes, and related data structures
`internal/ls/changetrackerimpl.go`	Change tracking implementation for applying text edits and code modifications
`internal/printer/changetrackerwriter.go`	Writer implementation for tracking position changes during code generation
`internal/modulespecifiers/specifiers.go`	Enhanced module specifier generation with autoimport support
`internal/ls/organizeimports.go`	Import organization utilities and comparison functions
Various utility files	Helper functions, type conversions, and API enhancements to support autoimport functionality

internal/ls/completions.go

internal/ls/changetrackerimpl.go

jakebailey · 2025-08-15T17:55:49Z

internal/format/indent.go

@@ -139,7 +139,7 @@ func getActualIndentationForListItem(node *ast.Node, sourceFile *ast.SourceFile,
 		// VariableDeclarationList has no wrapping tokens
 		return -1
 	}
-	containingList := getContainingList(node, sourceFile)
+	containingList := GetContainingList(node, sourceFile)


I didn't know this func existed; I wonder if it's general enough to use for sig help. (No action needed, just opining)

jakebailey · 2025-08-15T17:57:14Z

internal/format/indent.go

 }

-func findFirstNonWhitespaceColumn(startPos int, endPos int, sourceFile *ast.SourceFile, options *FormatCodeSettings) int {
+func FindFirstNonWhitespaceColumn(startPos int, endPos int, sourceFile *ast.SourceFile, options *FormatCodeSettings) int {


I am suspicious of this function, given it appears to return the column in terms of runes? I'm not sure it walks the chars correctly either, hmm...

This is what I was writing when I first went "wait, do we work in runes or in byte offsets for columns? Looks inconsistent right now". Both ways look wrong to some part of the stack around here because of that inconsistency.

Yeah, I think we need everything to be UTF-8 byte offsets, until they hit the LS and get converted based on the client preferences.

The only exception might be symbol baselines (UTF-16 compat?), source maps, and maybe the API, and maybe printed diagnostics? (That's a lot of exceptions...)

Related, #1578

internal/ls/changetrackerimpl.go

internal/printer/printer.go

internal/lsp/server.go

jakebailey · 2025-08-15T18:06:22Z

The import in the demo is inserted in a non-pretty way; is that something being worked on?

…o autoimport

iisaduan · 2025-08-15T20:21:45Z

The import in the demo is inserted in a non-pretty way; is that something being worked on?

Yes, this is a formatting bug/limitation. Strada formats with a sourceFileLike, and theres a lot of places in the formatter where synthesized nodes aren't handled

Edit: Fixed with help from @weswigham New statements come out pretty now (haven't updated the demo vid yet tho)

internal/ast/utilities.go

internal/ls/utilities.go

internal/fourslash/tests/gen/completionsObjectLiteralModuleExports_test.go

gabritto · 2025-08-15T22:31:47Z

internal/fourslash/tests/manual/autoImportCompletion_test.go

@@ -0,0 +1,145 @@
+package fourslash_test


Technically the tests in internal/fourslash/tests/manual/ are supposed to be generated tests that had to be manually modified, and new tests go into internal/fourslash/tests/, though that doesn't have practical differences I think other than our own organization of things.

Yeah, I would suggest moving this file for clarity.

internal/ls/autoimportfixes.go

internal/ast/utilities.go

gabritto

This looks good, just had a couple comments and some (many? 😅) questions

internal/ls/types.go

internal/ls/completions.go

internal/ls/autoimportstypes.go

internal/ls/autoimports.go

…to generated nodes

internal/ls/changetrackerimpl.go

internal/ls/autoimportstypes.go

jakebailey · 2025-08-18T23:13:34Z

Tried it out, nice:

But, the import did appear with the wrong indent level:

(I am ignoring the ordering, since that's a different problem.)

iisaduan · 2025-08-19T18:03:32Z

internal/ls/changetrackerimpl.go

+	var initialIndentation, delta int
+	if options.indentation == nil {
+		// !!! indentation for position
+		// initialIndentation = format.GetIndentationForPos(pos, sourceFile, formatOptions, options.prefix == ct.newLine || scanner.GetLineStartPositionForPosition(pos, targetFileLineMap) == pos);


@jakebailey That part of the formatter isn't ported yet (getSmartIndent) and involves the FindFirstNonWhitespaceColumn functions, so I didn't include it

I wouldn't assume anything else is gonna necessitate porting more parts of getSmartIndent - they're only nominally "in the formatter" - none of the FormatX entrypoints use anything as-yet unported. Anything else is basically just part of the quickfix pipeline that lives elsewhere, for some reason.

internal/fourslash/fourslash.go

andrewbranch · 2025-08-19T19:39:56Z

internal/ls/autoimports.go

+	isFromPackageJson bool
+}
+
+type exportInfoMap struct {


I would have liked to see this data structure rethought, for a few reasons:

Storing symbols is problematic; that's why there's a lot of complexity around serializing and "rehydrating" symbols. Some symbols are checker-generated, which we have to be extra careful of now that we have multiple checkers.

A lot of up-front checker work goes into building this data structure, which is super tailored to providing global completions with no prefix text, which was justified in Strada by caching it across most edits to the same file. Without that caching in place, or even in a future where we rethink the caching strategy, building this wastes a lot of work a lot of the time.

The two points above make it unclear how to integrate package.json auto imports - it would be nice to be able to process those without a program/checker, but this data structure relies on having those.

"Rehydrating" symbol info across requests has been a source of crashes in the past, so it might pay off to revisit from a clean slate.

A checker-free search of files could be massively parallel; building this is going to be single-threaded over potentially thousands of files.

All that said, it seems like the overriding motivation is to get some form of auto imports implemented fast, so a direct port makes sense. But I see a strong potential that this goes the way of the initial project service port, with a relatively short lifetime before getting a proper rewrite.

andrewbranch · 2025-08-19T19:42:25Z

internal/ls/autoimports.go

+	var exportInfos []*SymbolExportInfo
+	// The new way: `exportMapKey` should be in the `data` of each auto-import completion entry and
+	// sent back when asking for details.
+	exportInfos = l.getExportInfoMap(ch, sourceFile, preferences).get(sourceFile.Path(), ch, exportMapKey)


Probably need to pass ctx and check for cancellation where Strada does.

andrewbranch · 2025-08-19T19:48:06Z

internal/ls/completions.go

+	cb func(*resolvingModuleSpecifiersForCompletions) *ImportFix,
+) *ImportFix {
+	// !!! timestamp
+	// Under `--moduleResolution nodenext` or `bundler`, we have to resolve module specifiers up front, because


A bunch of code needs to be deleted, because these are the only module resolution modes existing in Corsa / 6.0. All auto import completions should be "fully resolved," which should dramatically simplify the code in this file.

andrewbranch · 2025-08-19T19:48:48Z

internal/ls/completions.go

@@ -4654,6 +5094,11 @@ func hasCompletionItem(clientOptions *lsproto.CompletionClientCapabilities) bool
 	return clientOptions != nil && clientOptions.CompletionItem != nil
 }

+// strada TODO: this function is, at best, poorly named. Use sites are pretty suspicious.
+func compilerOptionsIndicateEsModules(options *core.CompilerOptions) bool {
+	return options.Module == core.ModuleKindNone || options.GetEmitScriptTarget() >= core.ScriptTargetES2015 || options.NoEmit.IsTrue()


Always true in Corsa / 6.0

andrewbranch · 2025-08-19T19:50:09Z

internal/ls/languageservice.go

@@ -23,6 +23,11 @@ func (l *LanguageService) GetProgram() *compiler.Program {
 	return l.host.GetProgram()
 }

+func (l *LanguageService) GetPackageJsonAutoImportProvider() *compiler.Program {
+	// !!! packageJsonAutoImportProvider
+	return l.GetProgram()


I don't think this should be stubbed this way; couldn't this cause duplicate work?

iisaduan added 3 commits August 10, 2025 20:43

initial

d108e2e

fourslash completion filtertext

e450fbf

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

2159797

…o autoimport

fuzzymatch

fd072cf

gabritto reviewed Aug 11, 2025

View reviewed changes

internal/fourslash/fourslash.go Outdated Show resolved Hide resolved

gabritto reviewed Aug 11, 2025

View reviewed changes

internal/scanner/scanner.go Outdated Show resolved Hide resolved

jakebailey reviewed Aug 11, 2025

View reviewed changes

internal/ls/completions.go Outdated Show resolved Hide resolved

iisaduan added 5 commits August 14, 2025 15:38

fix bugs, add tests, remove extra preferences

f28767b

cleanup

1f582ed

refactor importFix struct

9eac6f1

refactor trackeredit struct

98404fb

reallow check filtertext

8b8adb4

iisaduan marked this pull request as ready for review August 15, 2025 17:40

Copilot AI review requested due to automatic review settings August 15, 2025 17:40

Copilot AI reviewed Aug 15, 2025

View reviewed changes

internal/ls/completions.go Outdated Show resolved Hide resolved

internal/ls/changetrackerimpl.go Show resolved Hide resolved

jakebailey reviewed Aug 15, 2025

View reviewed changes

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

b13ee93

…o autoimport

jakebailey requested a review from weswigham August 15, 2025 21:26

iisaduan changed the title ~~[DRAFT] autoimport~~ autoimport completions Aug 15, 2025

merge changes that didnt go with

357432a

weswigham requested changes Aug 15, 2025

View reviewed changes

internal/ast/utilities.go Outdated Show resolved Hide resolved

weswigham reviewed Aug 15, 2025

View reviewed changes

internal/ls/utilities.go Outdated Show resolved Hide resolved

gabritto reviewed Aug 15, 2025

View reviewed changes

internal/fourslash/tests/gen/completionsObjectLiteralModuleExports_test.go Outdated Show resolved Hide resolved

gabritto reviewed Aug 15, 2025

View reviewed changes

internal/ls/autoimportfixes.go Show resolved Hide resolved

iisaduan added 2 commits August 15, 2025 16:36

fix broken test and use textpos methods

f0f88dc

formatting bugs/function clean up

7a44815

gabritto reviewed Aug 18, 2025

View reviewed changes

internal/ast/utilities.go Outdated Show resolved Hide resolved

gabritto reviewed Aug 18, 2025

View reviewed changes

completions comments, remove deprecated userpreferences, add parents …

e84c1fd

…to generated nodes

iisaduan requested review from weswigham and andrewbranch August 18, 2025 21:34

iisaduan commented Aug 18, 2025

View reviewed changes

internal/ls/changetrackerimpl.go Show resolved Hide resolved

gabritto approved these changes Aug 18, 2025

View reviewed changes

jakebailey reviewed Aug 18, 2025

View reviewed changes

internal/ls/autoimportstypes.go Show resolved Hide resolved

iisaduan commented Aug 19, 2025

View reviewed changes

andrewbranch requested changes Aug 19, 2025

View reviewed changes

autoimport completions #1553

Are you sure you want to change the base?

autoimport completions #1553

Conversation

iisaduan commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexwork1611 commented Aug 11, 2025

Uh oh!

iisaduan commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Aug 15, 2025

Uh oh!

iisaduan commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gabritto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andrewbranch Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iisaduan commented Aug 11, 2025 •

edited

Loading

iisaduan commented Aug 11, 2025 •

edited

Loading

iisaduan commented Aug 15, 2025 •

edited

Loading

jakebailey commented Aug 18, 2025 •

edited

Loading

andrewbranch Aug 19, 2025 •

edited

Loading