feat(packagejson): remove RWMutex contention in InfoCache with atomic flag + SyncMap #1576
+12
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SyncMap - Replaced sync.RWMutex with atomic.Bool for thread-safe readonly flag - Switched to collections.SyncMap for concurrent cache access - Updated getPackageJsonInfo to use new IsReadonly() method - Added SetReadonly method for efficient readonly state management - Enhanced Get/Set operations for improved performance and thread safety
camc314
force-pushed
the
c/lock-free-get-pkg-json
branch
from
41621a5 to
05b3aef
Compare
camc314
changed the title
jakebailey
reviewed
Aug 13, 2025
|
Time to go faster! Thanks @jakebailey and @sheetalkamat, your review comments have shaved off some more time 
|
jakebailey
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff when running tsgo against vscode repo (top = before, bottom = after)
Diff when running tsgolint against vscode repo (top = before, bottom = after)
VIsible in the flamegraphs, the lock contention when getting
package.jsons from the cache is basically non-existant now