Skip to content

Conversation

sheetalkamat
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 18:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports TypeScript's --ignoreConfig command line option feature from the upstream repository. The option allows users to explicitly ignore tsconfig.json files and compile with command line options and files only.

Key changes:

  • Added --ignoreConfig command line option and help text
  • Implemented logic to skip tsconfig.json discovery when the option is enabled
  • Added error message for when files are specified but tsconfig exists without --ignoreConfig

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/core/compileroptions.go Added IgnoreConfig field to CompilerOptions struct
internal/tsoptions/parsinghelpers.go Added parsing logic for ignoreConfig option
internal/tsoptions/declscompiler.go Added command line option declaration for ignoreConfig
internal/execute/tsc.go Implemented core logic for ignoring config files and error handling
internal/diagnostics/extraDiagnosticMessages.json Added diagnostic messages for the new feature
internal/diagnostics/diagnostics_generated.go Generated diagnostic message constants
internal/execute/tsctests/tsc_test.go Added comprehensive test cases for the feature
testdata/baselines/* Updated test baselines to include new help text and test outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant