Include docs on resolved client caps #2135
Merged
+1,238
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing documentation to resolved client capability structures that were forgotten in PR #2095. The changes include modifications to both the code generator script and the generated output file.
- Updated the generator to copy documentation from original LSP types to their resolved counterparts
- Added type-level and property-level documentation comments to all resolved client capability structures
- Documentation includes "Since:" version markers and "Proposed" flags where applicable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/lsp/lsproto/_generate/generate.mts |
Modified generator to add documentation to resolved types by copying from source structures and adding property-level docs |
internal/lsp/lsproto/lsp_generated.go |
Generated file with comprehensive documentation added to all resolved client capability types and their properties |
andrewbranch
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to include these in #2095. Annoying to not have docs.