Skip to content

Reopen test case for base64_url response body encoding#8839

Merged
msyyc merged 2 commits intomainfrom
copilot/reopen-test-case-encode-bytes
Oct 28, 2025
Merged

Reopen test case for base64_url response body encoding#8839
msyyc merged 2 commits intomainfrom
copilot/reopen-test-case-encode-bytes

Conversation

Copy link
Contributor

Copilot AI commented Oct 28, 2025

Uncomments previously disabled test assertions for base64_url() response body encoding. These tests were temporarily commented out pending a fix in typespec-azure (#2411), which has now been released.

Changes

  • Uncommented assert expected == client.response_body.base64_url() in test_encode_bytes.py
  • Uncommented assert expected == await client.response_body.base64_url() in test_encode_bytes_async.py
  • Added changelog entry

Reference: Azure/autorest.python#3253

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/astro.js build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[python] reopen test case</issue_title>
<issue_description>Reopen test case for https://github.com/microsoft/typespec/blob/5d549c414f9a359fd768f5130de4f029c8cb67f9/packages/http-client-python/generator/test/generic_mock_api_tests/test_encode_bytes.py and

# will reopen after TCGC release a fix version for https://github.com/Azure/typespec-azure/pull/2411
# assert expected == await client.response_body.base64_url()
with reference of Azure/autorest.python#3253.

NOTE:

  • DO add changelog</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
@msyyc msyyc marked this pull request as ready for review October 28, 2025 07:56
@msyyc msyyc enabled auto-merge October 28, 2025 07:57
Copilot AI changed the title [WIP] Reopen test case for encode bytes functionality Reopen test case for base64_url response body encoding Oct 28, 2025
Copilot AI requested a review from msyyc October 28, 2025 08:10
@msyyc msyyc added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 274ce60 Oct 28, 2025
33 checks passed
@msyyc msyyc deleted the copilot/reopen-test-case-encode-bytes branch October 28, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[python] reopen test case

3 participants