[woff2] Fix gcc 15 missing header issue #45132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 15 reduced some transitive includes in libstdc++, so `stdint.h` is no longer being pulled in to woff2's `output.h`, causing a compile error on its use of `uint8_t`. There is an open pull request with the fix (google/woff2#176), but upstream maintainers haven't responded to it; let's patch it ourselves.
Mengna-Li
approved these changes
Apr 21, 2025
| #define WOFF2_WOFF2_OUT_H_ | ||
|
|
||
| +#include <stdint.h> | ||
| + |
Mengna-Li
added
category:port-bug
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Apr 22, 2025
This includes a patch to woff2, which lets it build on GCC 15. See microsoft/vcpkg#45132
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Apr 22, 2025
This includes a patch to woff2, which lets it build on GCC 15. See microsoft/vcpkg#45132 This has had a very minor effect on the anti-aliasing in one screenshot test, so I've rebaselined it.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Apr 22, 2025
This includes a patch to woff2, which lets it build on GCC 15. See microsoft/vcpkg#45132
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Apr 22, 2025
This includes a patch which lets it build on GCC 15. See microsoft/vcpkg#45132
trflynn89
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Apr 22, 2025
This includes a patch which lets it build on GCC 15. See microsoft/vcpkg#45132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 15 reduced some transitive includes in libstdc++, so
stdint.his no longer being pulled in to woff2'soutput.h, causing a compile error on its use ofuint8_t.There is an open pull request with the fix (google/woff2#176), but upstream maintainers haven't responded to it; let's patch it ourselves.
./vcpkg x-add-version --alland committing the result.