[ned14-internal-quickcpplib] fix install #45258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Bobini1 please test this PR. |
LilyWangLL
added
the
category:port-bug
LilyWangLL
reviewed
Apr 28, 2025
Contributor
|
Hi, I would like to repeat that the issue persists. I can't use this library on Linux. |
Contributor
Author
|
Waiting for the maintainer reply on ned14/quickcpplib#62 |
added 2 commits
May 14, 2025 16:31
Contributor
Author
|
@Bobini1 Please validate again. |
JackBoosY
commented
May 14, 2025
|
|
||
| # Emulate list(FILTER list INCLUDE|EXCLUDE REGEX regex) on cmake < 3.6 | ||
| function(list_filter listname op regexqualifer regex) | ||
| - if(CMAKE_VERSION VERSION_GREATER 3.59) |
Contributor
Author
There was a problem hiding this comment.
Since this port requires cmake version > 3.9, the else part is not needed.
Contributor
There was a problem hiding this comment.
It should be enough to fix this single line. There is no 3.59.
Contributor
There was a problem hiding this comment.
Change to if(0). Only the else branch has set(... PARENT_SCOPE).
(Of course nobody noticed before CMake 4.0...)
LilyWangLL
approved these changes
May 14, 2025
Contributor
Author
|
DO NOT merge this PR until @Bobini1 validated this. |
Contributor
|
@JackBoosY It works now, thanks! : ) |
LilyWangLL
added
the
info:needs-maintainer-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always exclude the third-part headers to prevent install error.
See https://github.com/ned14/quickcpplib/tree/master/include/quickcpplib
./vcpkg x-add-version --alland committing the result.Fixes #45231