Skip to content

Adding telemetry for devcmd environment usage #14023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Adding telemetry for devcmd environment usage #14023

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cfedda
Adding telemetry for devcmd environment usage
bobbrow Oct 30, 2025
eb1c2a7
Merge branch 'main' into bobbrow/envTelemetry
bobbrow Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Extension/src/LanguageServer/cppBuildTaskProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@ class CustomBuildTaskTerminal implements Pseudoterminal {
// However, this does not apply to processes that we spawn ourselves in the Pseudoterminal, so we need to specify the
// correct environment in order to emulate the terminal behavior properly.
this.options.env = getEffectiveEnvironment();
telemetry.logLanguageServerEvent('buildUsesEnvironmentOverride');
}

const splitWriteEmitter = (lines: string | Buffer) => {
Expand Down Expand Up @@ -498,18 +499,15 @@ class CustomBuildTaskTerminal implements Pseudoterminal {

private printBuildSummary(error: string, stdout: string, stderr: string, spawnResult: number): number {
if (spawnResult !== 0) {
telemetry.logLanguageServerEvent("cppBuildTaskError");
this.writeEmitter.fire(localize("build.finished.with.error", "Build finished with error(s).") + this.endOfLine);
return -1;
}
if (error || (!stdout && stderr && stderr.includes("error")) ||
(stdout && (stdout.includes("error C") || stdout.includes("LINK : fatal error")))) { // cl.exe compiler errors
telemetry.logLanguageServerEvent("cppBuildTaskError");
this.writeEmitter.fire(localize("build.finished.with.error", "Build finished with error(s).") + this.endOfLine);
return -1;
} else if ((!stdout && stderr) || // gcc/clang
(stdout && stdout.includes("warning C"))) { // cl.exe compiler warnings
telemetry.logLanguageServerEvent("cppBuildTaskWarnings");
this.writeEmitter.fire(localize("build.finished.with.warnings", "Build finished with warning(s).") + this.endOfLine);
return 0;
} else {
Expand Down