Add automation to catch potential issues with networks, volumes, bind mounts, and ports #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Jun 27, 2025
| case 'volume': | ||
| return [...curMounts, { | ||
| type: 'volume', | ||
| name: mount.Name, | ||
| source: mount.Source, | ||
| source: mount.Name, |
There was a problem hiding this comment.
This was a longstanding bug. The description of source on InspectContainersItemVolumeMount is The source of the volume mount (volume name), we should have been using mount.Name, not mount.Source (which is an obscure path deep in the Docker data dirs and not human-friendly).
The same bug existed for the Podman client.
We would have caught this mistake ages ago if we'd used satisfies here, so I added it to prevent possible future mistakes.
Comment on lines
-308
to
-310
|
|
||
| expect(testContainerId).to.be.a('string'); | ||
| expect(await validateContainerExists(client, defaultRunner, { containerId: testContainerId })).to.be.ok; |
There was a problem hiding this comment.
This is just moved down into it('RunContainerCommand')
Comment on lines
+351
to
+353
| ports: [{ hostPort: 8080, containerPort: 80 }], | ||
| exposePorts: [3000], // Uses the `--expose` flag to expose a port without binding it | ||
| publishAllPorts: true, // Which will then get bound to a random port on the host, due to this flag |
There was a problem hiding this comment.
Importantly, this is currently broken in Docker Desktop 4.42.x, unless you disable IPv6. See microsoft/vscode-containers#155 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267