Skip to content

Conversation

@olguzzar
Copy link
Contributor

No description provided.

@olguzzar olguzzar marked this pull request as ready for review October 21, 2025 04:38
@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 21, 2025
dbaeumer
dbaeumer previously approved these changes Oct 21, 2025
Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olguzzar Just a few minor changes. LGTM!

Co-authored-by: Nick Trogh <ntrogh@hotmail.com>
olguzzar and others added 3 commits October 21, 2025 16:31
Co-authored-by: Nick Trogh <ntrogh@hotmail.com>
Co-authored-by: Nick Trogh <ntrogh@hotmail.com>
mjbvz
mjbvz previously approved these changes Oct 21, 2025
roblourens
roblourens previously approved these changes Oct 22, 2025
isidorn
isidorn previously approved these changes Oct 22, 2025
Copy link
Contributor

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. Some high level feedback:
a) I would reduce the marketing tone a bit, so it is more down to earch (the experience is far from perfect)
b) Try to make it a bit more concise. I think we can save on one paragraph
c) I would embrace some of the shortcomings and clearly state that we are investing in this and looking for feedback. For example BYOK currently does not work with Completions or with NES.


The Language Model Chat Provider API is just the beginning of bringing more model choice to you. As this model ecosystem grows, we expect to see:

* More specialized models for specific programming languages and domains
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The what's next bullet list needs work. Currently all 3 items are fuzzy and I am not sure what they actually mean. I suggest to instead mention:

  • Model management UI that allows you to learn about model capabilities and manage models
  • Smoother flow for installing extensions that contribute language models
  • Improvements to the built-in language model providers - using latest provider APIs, having specialised prompts depending on the model

You can also check with @dineshc-msft as members of his team are taking over some of the built-in BYOK experiences and he might have feedback on what's coming.

@olguzzar olguzzar dismissed stale reviews from isidorn and roblourens via 250c415 October 22, 2025 14:35
@olguzzar olguzzar requested a review from isidorn October 22, 2025 15:04
@ntrogh ntrogh merged commit e6f31bc into microsoft:main Oct 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants