Sync with template: Fix duplicate server handlers on concurrent restarts#401
Merged
Sync with template: Fix duplicate server handlers on concurrent restarts#401
Conversation
- Move _disposables cleanup outside lsClient guard in restartServer() so disposables are always released, even when no previous client existed. - Wrap lsClient.stop() in deactivate() with try/catch to prevent unhandled rejections during extension deactivation. Source: microsoft/vscode-python-tools-extension-template#259 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition issue where duplicate server handlers could be registered during concurrent server restarts. The fix ensures proper cleanup of disposables and handles potential errors during server shutdown.
Changes:
- Move disposable cleanup outside the lsClient guard in restartServer() to ensure cleanup occurs even when no previous client existed
- Add error handling around lsClient.stop() in deactivate() to prevent unhandled promise rejections
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension.ts | Wraps lsClient.stop() with try/catch to handle deactivation errors gracefully |
| src/common/server.ts | Moves _disposables cleanup outside the lsClient guard to ensure consistent cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
heejaechang
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: microsoft/vscode-python-tools-extension-template#259