Skip to content

fix failing tests for inline debugging #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

fix failing tests for inline debugging #806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34c6c34
fix failing tests for inline debugging
eleanorjboyd Sep 11, 2025
dce6509
Merge branch 'main' into sure-dragonfly
eleanorjboyd Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
235 changes: 23 additions & 212 deletions src/test/unittest/inlineValue/pythonInlineValueProvider.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import * as sinon from 'sinon';
import { use, expect } from 'chai';
import { EXTENSION_ROOT_DIR_FOR_TESTS } from '../../constants';
import { PythonInlineValueProvider } from '../../../extension/debugger/inlineValue/pythonInlineValueProvider';
import { workspace, Range, InlineValueContext, WorkspaceConfiguration } from 'vscode';
import { workspace, Range, InlineValueContext, WorkspaceConfiguration, InlineValue } from 'vscode';
import * as vscodeapi from '../../../extension/common/vscodeapi';

use(chaiAsPromised);
Expand Down Expand Up @@ -98,102 +98,39 @@ suite('Debugging - pythonInlineProvider', () => {
const context = { frameId: 0, stoppedLocation: new Range(4, 1, 4, 1) } as InlineValueContext;

const result = await inlineValueProvider.provideInlineValues(document, viewPort, context);
const expected = [
const expected: InlineValue[] = [
{
range: {
c: {
c: 0,
e: 0,
},
e: {
c: 0,
e: 4,
},
},
range: new Range(0, 0, 0, 4),
variableName: 'var1',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 0,
e: 6,
},
e: {
c: 0,
e: 10,
},
},
range: new Range(0, 6, 0, 10),
variableName: 'var2',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 1,
e: 0,
},
e: {
c: 1,
e: 4,
},
},
range: new Range(1, 0, 1, 4),
variableName: 'var3',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 2,
e: 0,
},
e: {
c: 2,
e: 4,
},
},
range: new Range(2, 0, 2, 4),
variableName: 'var4',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 3,
e: 0,
},
e: {
c: 3,
e: 4,
},
},
range: new Range(3, 0, 3, 4),
variableName: 'var5',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 4,
e: 7,
},
e: {
c: 4,
e: 11,
},
},
range: new Range(4, 7, 4, 11),
variableName: 'var1',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 4,
e: 14,
},
e: {
c: 4,
e: 18,
},
},
range: new Range(4, 14, 4, 18),
variableName: 'var2',
caseSensitiveLookup: false,
},
Expand Down Expand Up @@ -244,55 +181,19 @@ suite('Debugging - pythonInlineProvider', () => {
const result = await inlineValueProvider.provideInlineValues(document, viewPort, context);
const expected = [
{
range: {
c: {
c: 3,
e: 8,
},
e: {
c: 3,
e: 17,
},
},
range: new Range(3, 8, 3, 17),
expression: 'self.name',
},
{
range: {
c: {
c: 4,
e: 8,
},
e: {
c: 4,
e: 16,
},
},
range: new Range(4, 8, 4, 16),
expression: 'self.age',
},
{
range: {
c: {
c: 7,
e: 18,
},
e: {
c: 7,
e: 27,
},
},
range: new Range(7, 18, 7, 27),
expression: 'self.name',
},
{
range: {
c: {
c: 7,
e: 29,
},
e: {
c: 7,
e: 37,
},
},
range: new Range(7, 29, 7, 37),
expression: 'self.age',
},
];
Expand Down Expand Up @@ -352,16 +253,7 @@ suite('Debugging - pythonInlineProvider', () => {
const result = await inlineValueProvider.provideInlineValues(document, viewPort, context);
const expected = [
{
range: {
c: {
c: 11,
e: 0,
},
e: {
c: 11,
e: 10,
},
},
range: new Range(11, 0, 11, 10),
expression: 'person1.id',
},
];
Expand Down Expand Up @@ -411,128 +303,47 @@ suite('Debugging - pythonInlineProvider', () => {
const result = await inlineValueProvider.provideInlineValues(document, viewPort, context);
const expected = [
{
range: {
c: {
c: 0,
e: 0,
},
e: {
c: 0,
e: 9,
},
},
range: new Range(0, 0, 0, 9),
variableName: 'some_list',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 1,
e: 0,
},
e: {
c: 1,
e: 1,
},
},
range: new Range(1, 0, 1, 1),
variableName: 'x',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 2,
e: 4,
},
e: {
c: 2,
e: 5,
},
},
range: new Range(2, 4, 2, 5),
variableName: 'n',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 2,
e: 13,
},
e: {
c: 2,
e: 22,
},
},
range: new Range(2, 13, 2, 22),
variableName: 'some_list',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 2,
e: 27,
},
e: {
c: 2,
e: 28,
},
},
range: new Range(2, 27, 2, 28),
variableName: 'x',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 3,
e: 13,
},
e: {
c: 3,
e: 14,
},
},
range: new Range(3, 13, 3, 14),
variableName: 'n',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 3,
e: 16,
},
e: {
c: 3,
e: 17,
},
},
range: new Range(3, 16, 3, 17),
variableName: 'x',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 5,
e: 13,
},
e: {
c: 5,
e: 14,
},
},
range: new Range(5, 13, 5, 14),
variableName: 'n',
caseSensitiveLookup: false,
},
{
range: {
c: {
c: 5,
e: 16,
},
e: {
c: 5,
e: 17,
},
},
range: new Range(5, 16, 5, 17),
variableName: 'x',
caseSensitiveLookup: false,
},
Expand Down
Loading