Merged
Conversation
|
wouldn't it make sense if you include a test case for such a subtle bug/edge case? |
Contributor
Author
|
a contributing doc to explain how to add tests would have been nice |
Contributor
Author
|
@alexdima @lszomoru @joaomoreno I noticed you were able to create and merge your own PR within a few hours. It would be greatly appreciated if you could also take a look at this community-provided PR, which has been waiting for review for over 6 months. It addresses an existing bug and deserves attention so it doesn’t get lost. |
Member
|
@alexdima @aiday-mar @hediet can you take a look? |
alexdima
approved these changes
Feb 28, 2026
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
Thank you and appologies for the slow feedback
dmitrivMS
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #251