Fix HSL color decorator regex to support CSS Level 4 syntax variants #252348
+49
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color decorator was not recognizing valid HSL color syntax variants, specifically space-separated values (CSS Level 4) and decimal hue values.
Problem:
Given this JavaScript code:
Only the first HSL color would show a color decorator, despite all three being valid CSS syntax.
Root Cause:
The HSL parameter validation regex was too restrictive:
\s*,\s*
(36[0]|3[0-5][0-9]|[12][0-9][0-9]|[1-9]?[0-9])
Solution:
Updated the regex patterns to support modern CSS syntax:
\s*,\s*
to\s*[,\s]\s*
to accept both comma and space separators(?:\.\d+)?
suffix to allow decimal hue values like192.5
Supported HSL Syntax Variants:
hsl(192, 87%, 49%)
- traditional comma-separatedhsl(192 87% 49%)
- CSS Level 4 space-separatedhsl(192.5, 87.5%, 49.5%)
- decimal values with commashsl(192.5 87.5% 49.5%)
- decimal values with spacesTesting:
Fixes #193512.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.