Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Some fixes I've found using REST client#9

Open
benjaminr-ps wants to merge 4 commits intomicrosoft:masterfrom
benjaminr-ps:fixes
Open

Some fixes I've found using REST client#9
benjaminr-ps wants to merge 4 commits intomicrosoft:masterfrom
benjaminr-ps:fixes

Conversation

@benjaminr-ps
Copy link

It seems that these files are generated, so this PR can be used as reference fixing the generator hopefully.

@davidstaheli
Copy link

Thanks very much for this, @benjaminr-ps! We'll get to it ASAP.

@AlexRukhlin
Copy link
Contributor

We cannot modify generated files manually. However, recently we've re-generated them and I hope most of the issues have been resolved. However, LogicalOperations class still looks ugly. I'll investigate what I can do.

Thanks,
Alex

@AlexRukhlin
Copy link
Contributor

The serialization of the LogicalOperations class's (as any other) members is defined by its declaration in the server REST API controllers. IMO, serialization rules are case insensitive and the ugle look of the current state of the LogicalOperations class shouldn't cause any issue for vso-httpclient-java. However, I agree that it would be nice if the server team improves this class definition on the server. I've notified the team responsible for the REST clients' generation about this request. Thank you.

Alex

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants