DXC: Annotate new struct fields and enums#1989
Open
MarijnS95 wants to merge 2 commits intomicrosoft:mainfrom
Open
DXC: Annotate new struct fields and enums#1989MarijnS95 wants to merge 2 commits intomicrosoft:mainfrom
MarijnS95 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
MarijnS95
commented
Sep 3, 2024
MarijnS95
force-pushed
the
dxc-enum
branch
2 times, most recently
from
30917b0 to
478cef8
Compare
MarijnS95
requested review from
a team,
jevansaks and
vineeththomasalex
as code owners
For `DXC_FOURCC` it would have been awesome if we could have something like the following, if `const` methods were supported: ```cs public static const uint DXC_FOURCC(char ch0, char ch1, char ch2, char ch3) => ch0 | (ch1 << 8) | (ch2 << 16) | (ch3 << 24); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #474 (comment).
For
DXC_FOURCCit would have been awesome if we could have something like the following, ifconstmethods were supported: