Adding options to WindowsSettings resource#212
Open
AmelBawa-msft wants to merge 11 commits intomicrosoft:mainfrom
Open
Adding options to WindowsSettings resource#212AmelBawa-msft wants to merge 11 commits intomicrosoft:mainfrom
AmelBawa-msft wants to merge 11 commits intomicrosoft:mainfrom
Conversation
mdanish-kh
reviewed
Jun 28, 2025
resources/Microsoft.Windows.Settings/Microsoft.Windows.Settings.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Settings/Microsoft.Windows.Settings.psm1
Outdated
Show resolved
Hide resolved
…a-msft/winget-dsc into user/amelbawa/settings-2
mdanish-kh
reviewed
Jul 2, 2025
…s.psm1 Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
mdanish-kh
approved these changes
Jul 23, 2025
Contributor
mdanish-kh
left a comment
mdanish-kh
left a comment
There was a problem hiding this comment.
There are similar PSScriptAnalyzer warnings in the files in this PR and the entire project, but I think probably better to handle them all in a separate PR. This looks good!
Contributor
Author
Updated for the other lines as well 😊 Thank you ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added properties:
Validate values for properties (partial fix for Field value validation for Microsoft.Windows.Settings #199)
Not yet sure how to approach validating the properties that take
[Nullable(bool)]as it seems that callingInvoke-DscResourcewhile passing a string will translate toTrueat runtime. Maybe converting them to a string and parsing the value to a bool is the way to go?