Skip to content

Conversation

@aahmed-spec
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new assessment test (Test-Assessment.25420) to validate that Global Secure Access network logs are retained for at least 90 days to support security analysis and compliance requirements. The test checks Microsoft Entra diagnostic settings to ensure required log categories are enabled with adequate retention configured in Log Analytics workspaces or storage accounts.

Changes:

  • Implements comprehensive validation of diagnostic settings for four required Global Secure Access log categories
  • Evaluates retention periods across Log Analytics workspaces and storage account destinations
  • Generates detailed reports showing log category status, destination details, and retention metrics

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/powershell/tests/Test-Assessment.25420.ps1 New PowerShell test function that queries Azure diagnostic settings and workspace retention, evaluates compliance with 90-day minimum retention requirement, and generates detailed markdown reports
src/powershell/tests/Test-Assessment.25420.md Documentation file explaining the security risk of inadequate log retention and providing remediation guidance with links to configure diagnostic settings and workspace retention

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

aahmed-spec and others added 2 commits January 22, 2026 13:54
Copy link
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aahmed-spec Please, address my feedback.

@aahmed-spec aahmed-spec dismissed alexandair’s stale review January 23, 2026 13:00

made changes to the code as per the changes requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants