-
Notifications
You must be signed in to change notification settings - Fork 124
Network - 25420 - Network access logs are retained for security analysis and compliance requirements #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
25907a1 to
54665dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new assessment test (Test-Assessment.25420) to validate that Global Secure Access network logs are retained for at least 90 days to support security analysis and compliance requirements. The test checks Microsoft Entra diagnostic settings to ensure required log categories are enabled with adequate retention configured in Log Analytics workspaces or storage accounts.
Changes:
- Implements comprehensive validation of diagnostic settings for four required Global Secure Access log categories
- Evaluates retention periods across Log Analytics workspaces and storage account destinations
- Generates detailed reports showing log category status, destination details, and retention metrics
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/powershell/tests/Test-Assessment.25420.ps1 | New PowerShell test function that queries Azure diagnostic settings and workspace retention, evaluates compliance with 90-day minimum retention requirement, and generates detailed markdown reports |
| src/powershell/tests/Test-Assessment.25420.md | Documentation file explaining the security risk of inadequate log retention and providing remediation guidance with links to configure diagnostic settings and workspace retention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexandair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aahmed-spec Please, address my feedback.
c5b5181 to
7d71998
Compare
made changes to the code as per the changes requested
No description provided.