Skip to content
This repository was archived by the owner on Feb 20, 2021. It is now read-only.

Conversation

@daanvanhasselt
Copy link

I found 2 issues with the audio system:

  • If something went wrong in the device enumeration loop in FindAudioDevice, all the devices after that would be skipped because CHECK_HR jumped out of the loop. In my case the Kinect audio device would never be found.
  • KCBSensor::GetAudioBuffer was ignoring the amount of bytes requested and instead passing the sizeof this value as the amount of bytes to read. This resulted in the same number of bytes (4) being read all the time.

use continue instead. this way if one device fails, the rest of the devices still get a chance
i assume this was a typo, since it was always reading only 4 bytes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant