Fix CIDR validation logic to properly validate /8 masks#21
Closed
NiklavsE wants to merge 5 commits intomiddlewares:masterfrom
Closed
Fix CIDR validation logic to properly validate /8 masks#21NiklavsE wants to merge 5 commits intomiddlewares:masterfrom
NiklavsE wants to merge 5 commits intomiddlewares:masterfrom
Conversation
NiklavsE
changed the title
Member
|
@filisko Can you take a look to this PR? Thank you! |
Author
|
@filisko, could you please review this? |
Member
|
@NiklavsE hi, thanks for the PR. Currently we use GH actions as our CI. Were you aware of that? Sorry for the late reply, when I checked these changes a month ago, I played with the code to see if the old and new tests were really doing something and I wasn't very convinced (obviously, for edge cases), that's why I didn't approve it right away. Maybe I should check again. On your side, could you do some checks the same way I did? thanks! will check this these days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
isInCIDRfunction, as the previous logic did not properly match valid IPv4 CIDR blocks such as x.0.0.0/8.The comparison approach was adapted from Symfony HttpFoundation IpUtils.
The logic still only supports Ipv4.