Skip to content

Refactor: extract shared governance logic into governance-helpers crate#1189

Open
NachoPal wants to merge 2 commits intomainfrom
nacho/remove-duplicate-root-calls
Open

Refactor: extract shared governance logic into governance-helpers crate#1189
NachoPal wants to merge 2 commits intomainfrom
nacho/remove-duplicate-root-calls

Conversation

@NachoPal
Copy link
Copy Markdown
Contributor

@NachoPal NachoPal commented Apr 1, 2026

Overview

  • Extracts duplicated governance flow (Council → TC → FederatedAuthority) from util/upgrader and util/toolkit/commands/root_call.rs into a new shared util/governance-helpers crate
  • Both the upgrader and toolkit now delegate to governance_helpers::execute_governance_call() instead of maintaining their own copies of the voting/proposal logic
  • Adds governance_helpers=info to the toolkit's default log filter so governance step logs remain visible

#1189

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@NachoPal NachoPal requested a review from a team as a code owner April 1, 2026 14:12
@NachoPal NachoPal changed the title Refactor: extract shared governance logic into governance-helpers crate Refactor: extract shared governance logic into governance-helpers crate Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant