Skip to content

fix: add fail-fast validation for partial Terms and Conditions genesis input (PM-22033)#1215

Draft
m2ux wants to merge 1 commit intomainfrom
fix/PM-22033-partial-terms-conditions-genesis-validation
Draft

fix: add fail-fast validation for partial Terms and Conditions genesis input (PM-22033)#1215
m2ux wants to merge 1 commit intomainfrom
fix/PM-22033-partial-terms-conditions-genesis-validation

Conversation

@m2ux
Copy link
Copy Markdown
Contributor

@m2ux m2ux commented Apr 1, 2026

Overview

Addresses audit finding PM-22033 (Least Authority Node DIFF Audit, Feb 2026): partial Terms and Conditions genesis configuration is silently accepted instead of failing fast. When only one of the required values (hash or URL) is provided, genesis initialization skips without error, leaving storage uninitialized.

This PR adds explicit validation to reject partial input at genesis time and includes test coverage for the fail-fast behavior.

📐 Engineering

🗹 TODO before merging

  • Implementation complete
  • Tests pass
  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@m2ux m2ux self-assigned this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A2 Issue M: Partial Terms and Conditions Genesis Input Is Silently Accepted

1 participant