Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new "edit secret" command that allows users to update secret values using their system’s default editor. Key changes include new tests in test_helpers for JSON validation and hash verification, new helper functions (validate_json_content and shasum) as well as an added add_secret_version utility in the GCP module, and significant updates to app.py to support secret editing and preview functionality.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_utils/test_helpers.py | Added tests for JSON content validation and file hash computation |
| secrets_manager/utils/helpers.py | Introduced utility functions for JSON validation and SHA256 checksum |
| secrets_manager/utils/gcp.py | Updated functions to improve secret version listing and added version creation functionality |
| pyproject.toml | Added new dependency "textual-dev" |
| app.py | Added support for editing secrets via an external editor and refactored preview functionality |
| ) | ||
| yield Pretty({}, id="pretty-preview") | ||
| with self.app.suspend(): | ||
| os.system(f"{self.EDITOR} {temp_file.name}") |
There was a problem hiding this comment.
[nitpick] Consider quoting the file path in the os.system call to correctly handle paths with spaces. For example, wrap temp_file.name in quotes.
Suggested change
| os.system(f"{self.EDITOR} {temp_file.name}") | |
| os.system(f'{self.EDITOR} "{temp_file.name}"') |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
EDITORenv var)