Open
Conversation
ghost
requested review from
Collaborator
|
Since simple_command has recently reached its 1.0 release, I would still set an upper boundary to avoid breaking compatibility. Ideally we should refactor onesignal-ruby to use the new simple_command 1.0, but for now even setting an upper limit to |
MatteoJoliveau
requested changes
Jun 10, 2022
| spec.add_runtime_dependency 'activesupport', '>= 5.0.0', '< 8' | ||
| spec.add_runtime_dependency 'faraday', '>= 1', '< 3' | ||
| spec.add_runtime_dependency 'simple_command', '~> 0', '>= 0.0.9' | ||
| spec.add_runtime_dependency 'simple_command', '>= 0.0.9' |
Collaborator
There was a problem hiding this comment.
Suggested change
| spec.add_runtime_dependency 'simple_command', '>= 0.0.9' | |
| spec.add_runtime_dependency 'simple_command', '>= 0.0.9', '< 1' |
Handle 502 Server Error from OneSignal Servers
Introduce ServerError and ClientError
Get detailed error messages from server
Introduce APIRateLimitError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @bernardini687 and @MatteoJoliveau again. Please merge the latest PR about updated dependences.
thanks 🙏