Merged
Conversation
Update example autoload paths
…e it doesn't break tests
Improve testing for PHP 7.4
- the first arg UConverter->convert() has to be a string.
- as proved during tests, UConverter->convert() can return boolean sometimes.
- thus $utf8 can be boolean sometimes, not only string.
- but the full documentation of UConverter->convert() is currently missing on php docs.
- On strict_types, PHP cannot convert float to int.
- That's the behavior with strict_types when we call chr() passing a float:
- PHP 7.0 passes 0 instead -- this can be a silent error, not good.
- PHP 7.4 returns Fatal Error, which is better.
- This commit cast it to int before calling chr() to keep the previous behavior.
Add strict types (w/ modifications)
Change supported php versions, apply 8.0 fixes and build environment changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the supported PHP versions, and contains some breaking changes to improve compatibility with newer PHP installs.
Breaking changes to users who are upgrading:
declare(strict_types=1), which will cause errors for callers which are not using the correct scalar types.Bug fixes:
vendor/autoload.php, so they will work if this repository is checked out and used standalone.