Conversation
| @@ -1,4 +1,4 @@ | |||
| package com.example.party_player | |||
| package com.example.partyPlayer | |||
There was a problem hiding this comment.
Changed the package names by removing underscores to comply with Kotlin naming conventions stated here: https://kotlinlang.org/docs/reference/coding-conventions.html
There was a problem hiding this comment.
While they are two words, package names are usually all lowercase. Consider making this all lowercase.
| <?xml version="1.0" encoding="utf-8"?> | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| package="com.example.party_player"> | ||
| package="com.example.partyPlayer"> |
There was a problem hiding this comment.
Changed the package names by removing underscores to comply with Kotlin naming conventions stated here: https://kotlinlang.org/docs/reference/coding-conventions.html
| */ | ||
| @RunWith(AndroidJUnit4::class) | ||
| class ExampleInstrumentedTest { | ||
| class InstrumentedTest { |
There was a problem hiding this comment.
Changed the name of the test files to be a little more visibly unique. (Both test files began with "Example")
| * See [testing documentation](http://d.android.com/tools/testing). | ||
| */ | ||
| class ExampleUnitTest { | ||
| class UnitTest { |
There was a problem hiding this comment.
Changed the name of the test files to be a little more visibly unique. (Both test files began with "Example")
There was a problem hiding this comment.
While you're removing the "Example" prefix, rename the test to something that is more descriptive of what is being tested. "UnitTest" is implied here, based on the location of this class. What is being unit tested? Put that in the name of the class.
|
|
||
| /** | ||
| * Example local unit test, which will execute on the development machine (host). | ||
| * |
There was a problem hiding this comment.
Cleaned up the comments by removing blank gaps.
|
|
||
| /** | ||
| * Instrumented test, which will execute on an Android device. | ||
| * |
There was a problem hiding this comment.
Cleaned up the comments by removing blank gaps.
| android:supportsRtl="true" | ||
| android:theme="@style/AppTheme"> | ||
| <activity android:name=".MainActivity"> | ||
| <activity android:name="com.example.partyPlayer.MainActivity"> |
There was a problem hiding this comment.
Changed the package names by removing underscores to comply with Kotlin naming conventions stated here: https://kotlinlang.org/docs/reference/coding-conventions.html
| @@ -1,4 +1,4 @@ | |||
| package com.example.party_player | |||
| package com.example.partyPlayer | |||
There was a problem hiding this comment.
Changed the package names by removing underscores to comply with Kotlin naming conventions stated here: https://kotlinlang.org/docs/reference/coding-conventions.html
| @@ -1,15 +1,14 @@ | |||
| package com.example.party_player | |||
| package com.example.partyPlayer | |||
There was a problem hiding this comment.
Changed the package names by removing underscores to comply with Kotlin naming conventions stated here: https://kotlinlang.org/docs/reference/coding-conventions.html
|
I'll leave it up to the team to decide whether or not to merge. See inline commentary for more details. |
2 participants
Project Description:
This is a program/app that collects user music suggestions for a party and curates a playlist for the party based around the user suggestions as to satisfy all party-goers with different musical tastes
What I learned:
*Learned proper naming conventions for packages
*Learned how to efficiently rename multiple packages at once if necessary
Finding changes to make were a little difficult as there was not much code readily available