Carte2ct code review2#3
Open
Chriscarter17 wants to merge 5 commits intomasterfrom
Open
Conversation
|
It's not easy to tell what was changed here... as it appears that MainActivity.kt was deleted in one package, and then created in another. There are conflicting files as well. Without enough detail on the change, I don't recommend merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis of the program.
Was the program available in UC Github on time?
Is the program documented/commented well enough for you to understand?
Does the program compile?
Did not compile at first as a remote plugin is required as well as a spotify APK
Rationale behind your changes.
I did not change much as much of the code is proper functionality. The naming of functions is proper camel case as well as private and constant variables.
Three technical Concepts i learned: