Skip to content

Carte2ct code review2#3

Open
Chriscarter17 wants to merge 5 commits intomasterfrom
Carte2ct_CodeReview2
Open

Carte2ct code review2#3
Chriscarter17 wants to merge 5 commits intomasterfrom
Carte2ct_CodeReview2

Conversation

@Chriscarter17
Copy link
Copy Markdown
Collaborator

Analysis of the program.

  • Program is remote player that relies on spotify API.

Was the program available in UC Github on time?

  • program was available on github on time

Is the program documented/commented well enough for you to understand?

  • although the document itself is somewhat complicated, with there being almost no commented code describing what each portion does. I was able to figure out that a remote plugin is needed to make the code functional.
    Does the program compile?
    Did not compile at first as a remote plugin is required as well as a spotify APK
    Rationale behind your changes.
    I did not change much as much of the code is proper functionality. The naming of functions is proper camel case as well as private and constant variables.

Three technical Concepts i learned:

  • remote plugins can be used to access outside apps
  • one function can setup multiple onClickListeners
  • Exception catching is important when dealing with specific functions.

@discospiff
Copy link
Copy Markdown

It's not easy to tell what was changed here... as it appears that MainActivity.kt was deleted in one package, and then created in another. There are conflicting files as well. Without enough detail on the change, I don't recommend merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants