Skip to content

Preserve unknown test plan keys #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikeger merged 2 commits into from
Nov 17, 2025
Merged

Preserve unknown test plan keys #83

mikeger merged 2 commits into from
Nov 17, 2025

Conversation

@mikeger
Copy link
Owner

@mikeger mikeger commented Nov 15, 2025

Summary

  • rewrite TestPlanModel/TestTarget/Target to keep the original JSON and only swap out the testTargets array so unknown keys stick around
  • update the configurator logic and add regression coverage proving nested target metadata survives edits
  • add Workspace as a test dependency so we can build real TargetIdentity instances in the new tests

Testing

  • swift test

@mikeger mikeger mentioned this pull request Nov 15, 2025
Open
@mikeger mikeger force-pushed the preserve-test-plan-keys branch from 35aec4e to f007aed Compare November 15, 2025 22:59
@mikeger mikeger merged commit 641ce09 into main Nov 17, 2025
4 checks passed
@mikeger mikeger deleted the preserve-test-plan-keys branch November 17, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikeger