Skip to content

Bug Hunt 2 addressing #1641 #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandipratamaputra wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Bug Hunt 2 addressing #1641 #1643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions collective_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,36 @@ optional<CollectiveName> CollectiveBuilder::generateName() const {
auto leader = creatures[0].creature;
ret.viewId = leader->getViewObject().id();
if (locationName && raceName)
ret.full = capitalFirst(*raceName) + " of " + *locationName;
ret.full = " The " + capitalFirst(*raceName) + " of " + capitalFirst(*locationName);
// =========================================================
// When Localization project is on progress, perhaps consider using this format
// after making an identifier function for these section.
// The usage is for anything with connector (of, and, from, etc).
// Example 1:
// File directory: /mod/localization/Japanese/JPN_LOC.txt
// (resource file name can be arbitrary, used for debugging address,
// the real that matters is the previous folder's name)
// ==========================
// #/mod/localization/Japanese/JPN_LOC.txt (Arbitrary section used for debugging)
// { locationName&&RaceName = locationName + "の" + raceName }
// Example 2:
// File directory: /mod/localization/Indonesian/INA_LOC.txt
// (file name can be arbitrary, used for debugging address,
// the real that matters is the previous folder's name)
// ==========================
// #/mod/localization/Japanese/INA_LOC.txt (Arbitrary section used for debugging)
// { locationName&&RaceName = raceName locationName }
// =========================================================
// DeliveryService
// =========================================================
else if (!!leader->getName().first())
ret.full = leader->getName().title();
else if (raceName)
ret.full = capitalFirst(*raceName);
ret.full = "The " + capitalFirst(*raceName);
else
ret.full = leader->getName().title();
if (locationName)
ret.shortened = *locationName;
ret.shortened = "The " + capitalFirst(*locationName);
else if (auto leaderName = leader->getName().first())
ret.shortened = *leaderName;
if (raceName)
Expand Down