-
-
Notifications
You must be signed in to change notification settings - Fork 122
Bug Hunt addressing #1592 #1640 #1650 #1655 #1646 #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
Changes from all commits
77c76a9
770bc7d
ef08d04
890632f
570cc90
c0e0749
9daf9cc
307e333
a927b9e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -1188,6 +1188,19 @@ | |||
| Fx { TELEPORT_OUT } | ||||
| DestroyWalls BASH | ||||
| } | ||||
| overrideMovement = true | ||||
| movementSet = { | ||||
| forcibleTraits = { FLY SWIM WADE WALK } | ||||
| } | ||||
| itemDrop = {{{{Simple "Rock"} 1 { 3 }}}} | ||||
| strength2 = { | ||||
| 300 BOULDER | ||||
| 100 DIG | ||||
| 1900 HOSTILE_DIG | ||||
| 2000 HOSTILE_DIG_NO_SKILL | ||||
| } | ||||
| #destroyFX = { ROCK_CLOUD Rgb 200 200 200 255 } | ||||
| #tryDestroyFX = { DESTROY_FURNITURE Rgb 200 200 200 255 } | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove redundant comments
Suggested change
|
||||
| } | ||||
| "SNOW_WALL" inherit "CASTLE_WALL" | ||||
| { | ||||
|
|
||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -3213,8 +3213,15 @@ SGuiElem GuiBuilder::drawEquipmentAndConsumables(const PlayerInfo& minion, bool | |||||||||||||||||||||
| WL(button, | ||||||||||||||||||||||
| getButtonCallback({UserInputId::CREATURE_EQUIPMENT_ACTION, | ||||||||||||||||||||||
| EquipmentActionInfo{minion.creatureId, items[i].ids, items[i].slot, ItemAction::LOCK}})), | ||||||||||||||||||||||
| items[i].locked ? WL(viewObject, ViewId("key")) : WL(mouseHighlight2, WL(viewObject, ViewId("key_highlight"))), | ||||||||||||||||||||||
| getTooltip({"Locked items won't be automatically swapped by minion."}, THIS_LINE + i) | ||||||||||||||||||||||
| items[i].locked ? | ||||||||||||||||||||||
| WL(viewObject, ViewId("gui_inventory_locked")) : | ||||||||||||||||||||||
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_inventory_locked_highlighted")): | ||||||||||||||||||||||
| !items[i].locked ? | ||||||||||||||||||||||
| WL(viewObject, ViewId("gui_inventory_unlocked")) : | ||||||||||||||||||||||
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_inventory_unlocked_highlighted"))), | ||||||||||||||||||||||
|
Comment on lines
+3217
to
+3221
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IDs are not matching the entries from
Suggested change
|
||||||||||||||||||||||
| items[i].locked ? | ||||||||||||||||||||||
| getTooltip({"Item Locked. Locked items won't be automatically swapped by minion."}, THIS_LINE + i): | ||||||||||||||||||||||
| getTooltip({"Item Not Locked. Allows minions to automatically swap it."}, THIS_LINE + i) | ||||||||||||||||||||||
| ); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| itemElems.push_back( | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -64,8 +64,14 @@ static void addThird(const Creature* c, MsgType type, const string& param) { | |||||
| case MsgType::BURN: msg = c->getName().the() + " burns in the " + param; unseenMsg = "You hear a horrible scream"; break; | ||||||
| case MsgType::DROWN: msg = c->getName().the() + " drowns in the " + param; unseenMsg = "You hear a loud splash" ;break; | ||||||
| case MsgType::SET_UP_TRAP: msg = c->getName().the() + " sets up the trap"; break; | ||||||
| case MsgType::KILLED_BY: msg = c->getName().the() + " is "+ | ||||||
| c->getAttributes().getDeathDescription() + " by " + param; break; | ||||||
| case MsgType::KILLED_BY: | ||||||
| if ((c->getName().the())compare(param) = 0) | ||||||
| // If creature name compared to what killed it, | ||||||
| // has zero difference, perform the code below. | ||||||
| msg = c->getName().the() + " has committed suicide."; | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider restoring the cause of death, for instance:
Suggested change
|
||||||
| else | ||||||
| msg = c->getName().the() + " is "+ | ||||||
| c->getAttributes().getDeathDescription() + " by " + param; break; | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unindent
Suggested change
|
||||||
| case MsgType::TURN: msg = c->getName().the() + " turns " + param; break; | ||||||
| case MsgType::BECOME: msg = c->getName().the() + " becomes " + param; break; | ||||||
| case MsgType::COPULATE: msg = c->getName().the() + " copulates " + param; break; | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant comments