add transaction lifecycle service#519
Merged
milah-247 merged 2 commits intomilah-247:mainfrom Apr 1, 2026
Merged
Conversation
|
@Jayking40 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@Jayking40 you pushed from main |
Owner
|
You have conflict |
Owner
|
@Jayking40 you're pushing from main not branch |
Owner
|
Push from your branch not main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Backend] Feature: Transaction Service
Summary
Implemented a transaction lifecycle service for the backend so transaction writes are validated consistently, transaction history can be queried with richer filters, and merchants can manage refunds, reconciliation, and reporting from the same transaction domain model.
Changes
Testing
Unit tests written for:
Transaction service validation and lifecycle flows
Transaction routes and user history route behaviour
Repository round-trip, nullability, merchant isolation, and Horizon fallback cases
Edge cases covered:
Duplicate transaction recording
Invalid wallet addresses, invalid amounts, and reversed date ranges
Refund ownership checks and invalid refund targets
Horizon failure with database fallback
Merchant-scoped filtering and reconciliation/report filters
Manual testing steps (if applicable):
Ran targeted backend Jest suites for the transaction service, routes, repositories, property tests, and Horizon fallback flow
Ran focused ESLint checks on the touched transaction files
Closes #352