Feature: enabling continuous button press#7
Open
shaolin405mi16 wants to merge 12 commits intomilkcan:masterfrom
Open
Feature: enabling continuous button press#7shaolin405mi16 wants to merge 12 commits intomilkcan:masterfrom
shaolin405mi16 wants to merge 12 commits intomilkcan:masterfrom
Conversation
…nputValue is updated inside the callback)
…thout ngTouch plugin
Contributor
Author
|
further commits to make usable both on PC browsers and touchscreen devices. Introduced
Also, introduced a 600ms delay before autorepeat for better usability. |
|
Is this going to get merged to master? |
Contributor
Author
|
@mikepc For the time being, use my forked master instead. Will get this pull request without a conflict later. |
…uous-button-press
Contributor
|
Just needs to be cleaned up and I can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this patch includes one bugfix (when returning negative value), and also a huge feature addition.
This enables "autorepeat" feature: numbers continuously up/down while pressing increment/decrement buttons. So you don't have to click/tap up/down buttons number of times anymore, in order to increase/decrease numbers plenty. To accomplish this, I changed the way negative sign and current value(s) are displayed (from
ng-bindto direct DOM manipulation).Also, since touchscreen devices (such as smartphones and tablets) cannot handle
mousedownandmouseupevents, I addedng-touchstartandng-touchenddirectives. If you add ngTouch ( https://github.com/nglar/ngTouch ) module, autorepeat feature will be enabled on touchscreen devices as well. Without ngTouch module, these directives are simply ignored.Hope you'll like this.