Skip to content

Feature/disable drm cast pip #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature/disable drm cast pip #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96b99f1
disable cast and pip for drm streams
gregdolby Oct 29, 2024
650d936
hide cast button for drm
gregdolby Oct 29, 2024
f484616
disable all ui for cast when drm stream
gregdolby Oct 29, 2024
7db1134
fix cast enabled computed method
gregdolby Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/VideoPlayerControls/VideoPlayerControlsCast.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
:class="[isMobile ? 'dropdown-item d-flex row mx-0' : 'mobile-setting']"
v-if="castAvailable && !options.loading"
v-if="castAvailable && !options.loading && !this.viewer.drm"
@click="clickCast"
>
<div :class="[isMobile ? '' : 'mobile-setting']">
Expand Down Expand Up @@ -29,6 +29,9 @@ export default {
castAvailable: (state) => state.castAvailable,
options: (state) => state.castOptions,
}),
...mapState('Params', {
viewer: (state) => state.viewer,
}),
},
methods: {
clickCast() {
Expand Down
17 changes: 13 additions & 4 deletions src/components/VideoPlayerControls/VideoPlayerControlsContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
:streamId="streamId"
v-if="showButton('settings')"
/>
<VideoPlayerControlsCast v-if="showButton('cast') && castAvailable" />
<VideoPlayerControlsCast v-if="castEnabled" />
<VideoPlayerControlsPip v-if="pipEnabled" />
<VideoPlayerControlsFullscreen
v-if="showButton('fullscreen')"
Expand All @@ -30,7 +30,7 @@
/>
<span
v-if="
(showButton('cast') && castAvailable) ||
castEnabled ||
(isLive && pipEnabled && showButton('pip') && isVideoTag) ||
showButton('fullscreen')
"
Expand All @@ -48,7 +48,9 @@
<div class="dropdown-header d-flex m-0 col-12">
<h6 class="p-0 m-0">Options</h6>
</div>
<VideoPlayerControlsCast v-if="showButton('cast') && castAvailable" />
<VideoPlayerControlsCast
v-if="showButton('cast') && castAvailable && !this.viewer.drm"
/>
<VideoPlayerControlsPip v-if="pipEnabled" />
<VideoPlayerControlsFullscreen
v-if="showButton('fullscreen')"
Expand Down Expand Up @@ -101,6 +103,9 @@ export default {
isLive: (state) => state.isLive,
castAvailable: (state) => state.castAvailable,
}),
...mapState('Params', {
viewer: (state) => state.viewer,
}),
isVideoTag() {
return this.video?.nodeName === 'VIDEO'
},
Expand All @@ -109,9 +114,13 @@ export default {
this.showButton('pip') &&
document.pictureInPictureEnabled &&
this.isLive &&
this.isVideoTag
this.isVideoTag &&
!this.viewer.drm
)
},
castEnabled() {
return this.showButton('cast') && this.castAvailable && !this.viewer.drm
},
},
methods: {
...mapMutations('Controls', ['setDropup', 'toggleFullscreen']),
Expand Down