Skip to content

fix(website): prevent hydration mismatch in terminal demo #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SultokTheF wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(website): prevent hydration mismatch in terminal demo #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@ dist
*.log
.DS_Store
.agents
.cursor
.cursor


# MARK: You have ignore this
package-lock.json
3 changes: 3 additions & 0 deletions packages/website/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,6 @@ yarn-error.log*
# typescript
*.tsbuildinfo
next-env.d.ts

# MARK: You have ignore this
package-lock.json
12 changes: 8 additions & 4 deletions packages/website/src/components/terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,16 @@ const markAnimationCompleted = () => {
};

const Terminal = () => {
const [state, setState] = useState<AnimationState>(
didAnimationComplete() ? COMPLETED_STATE : INITIAL_STATE,
);
// #MARK: Before this fix, we read localStorage during render and could start from COMPLETED_STATE on the client.
// #MARK: That produced different first HTML on server vs client and triggered hydration mismatch.
const [state, setState] = useState<AnimationState>(INITIAL_STATE);

useEffect(() => {
if (didAnimationComplete()) return;
// #MARK: Read persisted completion only after mount so the first client render matches SSR output.
if (didAnimationComplete()) {
setState(COMPLETED_STATE);
return;
}

let cancelled = false;

Expand Down