Skip to content

remove space from line label so they are clickable #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderHott wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

remove space from line label so they are clickable #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/react-doctor/src/scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,13 @@ const printDiagnostics = (diagnostics: Diagnostic[], isVerbose: boolean): void =
const fileLines = buildFileLineMap(ruleDiagnostics);

for (const [filePath, lines] of fileLines) {
const lineLabel = lines.length > 0 ? `: ${lines.join(", ")}` : "";
logger.dim(` ${filePath}${lineLabel}`);
if (lines.length > 0) {
for (const line of lines) {
logger.dim(` ${filePath}:${line}`);
}
} else {
logger.dim(` ${filePath}`);
}
}
}

Expand Down Expand Up @@ -137,8 +142,13 @@ const formatRuleSummary = (ruleKey: string, ruleDiagnostics: Diagnostic[]): stri

sections.push("", "Files:");
for (const [filePath, lines] of fileLines) {
const lineLabel = lines.length > 0 ? `: ${lines.join(", ")}` : "";
sections.push(` ${filePath}${lineLabel}`);
if (lines.length > 0) {
for (const line of lines) {
sections.push(` ${filePath}:${line}`);
}
} else {
sections.push(` ${filePath}`);
}
}

return sections.join("\n") + "\n";
Expand Down