Merged
Conversation
- Create nearby.ts with layout detection (flex/grid/block), sibling gap measurement, insertion index computation, and React fiber component name resolution - Rewrite prompt.ts reposition section to produce focused, actionable instructions: parent layout info, child index movement, neighbor gaps, and smart margin suggestions based on gap vs parent gap - Support both vertical and horizontal flow axes Co-authored-by: Ben MacLaurin <ben-million@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance repositioning prompt accuracy by generating layout-aware, actionable instructions for ctrl+dragged components.
The previous prompt generation was less precise, relying on absolute Y coordinates and a verbose DOM dump. This PR introduces a new utility (
nearby.ts) to intelligently analyze the DOM structure (flex, grid, block layouts, gaps, margins) around the dragged element. This allowsprompt.tsto provide specific, incremental CSS suggestions (e.g., "add margin-top: 4px") and JSX reordering instructions, directly addressing the user's need for highly accurate agent positioning without CSS transforms.