Add support for mill build tool and make submodules permanent#1
Open
jurevreca12 wants to merge 7 commits intomilovanovic:masterfrom
Open
Add support for mill build tool and make submodules permanent#1jurevreca12 wants to merge 7 commits intomilovanovic:masterfrom
jurevreca12 wants to merge 7 commits intomilovanovic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am using sdf-fft in another project, and I would like to contribute back some changes.
In this pull request I did two things. I wrote a build configuration for the mill build tool, and made submodules a part of the repository.
Is there any reason why the submodules are not a part of the repository? If so, I can also contribute back a pull request with only the mill build script change (build.sc).
Please let me know, if you think this change would be helpful, I think it would simplify the workflow for people using mill instead of sbt. Additionally, I would like to bump the chisel version used by sdf-fft to at least 3.6.0, but ideally to > 5, just because the speed ups would make my life much easier. I might do a separate pull request for that if you are interested.
Pozdrav,
Jure